Repository navigation
Add multiple checksums - #311
Merged
Merged
Conversation
meretp
force-pushed
the
add_multiple_checksums
branch
2 times, most recently
from
November 24, 2022 12:14
5c29442 to
6cfafe1
Compare
nicoweidner
requested changes
Nov 25, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
Quite a few comments 😅
For comments that would require larger changes, please decide for yourself whether it still makes sense to incorporate them, in view of the upcoming refactor. We can also discuss that in a meeting
Signed-off-by: Jeffrey Otterson <otterson@yahoo.com>
Signed-off-by: Jeffrey Otterson <otterson@yahoo.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
add_multiple_checksums
branch
from
November 28, 2022 09:44
2422866 to
89c3f7b
Compare
nicoweidner
previously approved these changes
Nov 28, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
I noticed a few more small things, but looks very good now!
meretp
force-pushed
the
add_multiple_checksums
branch
2 times, most recently
from
November 28, 2022 12:53
a1ab8a9 to
f830eba
Compare
nicoweidner
previously approved these changes
Nov 28, 2022
meretp
force-pushed
the
add_multiple_checksums
branch
from
November 28, 2022 14:24
b80f30e to
d71003a
Compare
nicoweidner
previously approved these changes
Nov 28, 2022
added 8 commits
November 28, 2022 15:30
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
add_multiple_checksums
branch
from
November 28, 2022 14:31
d71003a to
af36fb5
Compare
nicoweidner
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the contribution from @jotterson, thanks!
fixes #185