Skip to content

fix(artifact-signer): order tsconfig keys for the lint rule - #341

Merged
harlan-zw merged 1 commit into
mainfrom
fix/artifact-signer-tsconfig-key-order
Sep 30, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
fix/artifact-signer-tsconfig-key-order

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

❓ Type of change

  • 🐞 Bug fix

📚 Description

#340 put paths at the end of compilerOptions. jsonc/sort-keys wants it before types, so lint on main fails with one error:

workers/artifact-signer/tsconfig.json 16:5 error Expected object keys to be in specified order. 'paths' should be before 'types' jsonc/sort-keys

This is the eslint --fix output. I missed linting the file in #340.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

#340 appended paths after skipLibCheck. jsonc/sort-keys wants it before types, so lint on main fails with one error.
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-pending The automated Review is waiting on a gate for this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-pending The automated Review is waiting on a gate for this head commit. labels Sep 30, 2026
@harlan-github-agent

harlan-github-agent Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-09-30 16:31 UTC.

GitHub merged this pull request.

No material findings were recorded.

Waiting for Baseline repair e5278c5f6b1d23ab3a72480920c97af838aa46b77f0c3519b27461e6eb35a161.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-pending The automated Review is waiting on a gate for this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. labels Sep 30, 2026
@harlan-zw
harlan-zw merged commit 1bb892d into main Sep 30, 2026
6 checks passed
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-pending The automated Review is waiting on a gate for this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. labels Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant