Repository navigation
fix(artifact-signer): resolve #shared in the worker typecheck - #340
Merged
Merged
Conversation
#309 imported #shared/skill-path into github-source.ts. The artifact-signer worker typechecks that file through a type import in checks.ts, and its tsconfig had no #shared mapping. CI skips the worker unless the lockfile changes, so main stayed red where nobody saw it.
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. Review completed. No finding above 80/100. |
harlan-github-agent
Bot
removed
harlan-agent-running
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
The artifact-signer typecheck fails on main since #309, which added a
#shared/skill-pathimport togithub-source.ts. The worker reaches that file through a type import inchecks.ts, and its tsconfig had no#sharedmapping:It fails on a clean main checkout too. CI missed it, most likely because of the task cache: the worker's cache inputs don't seem to cover the layer files it imports, so #309 restored an old green result. #335 changed the lockfile, which busted the cache and surfaced the error. I didn't confirm the cache key, so that part is a guess.
This adds the path mapping.
shared/skill-path.tshas no imports, so nothing else comes along.