Repository navigation
fix(daily-checkin): read cancelled runs through like skipped - #269
Merged
Merged
Conversation
…d concurrency queue-mates never started, so they carry no verdict. On 2026-09-21 two cancelled deploys in front of the run that shipped a1b4db6 read as consecutive failure
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
Author
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 470bd753-9dba-40dc-845b-57ac07e2906a |
harlan-github-agent
Bot
added
harlan-agent-blocked
harlan-github-agent
Bot
added
harlan-agent-running
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #266
❓ Type of change
📚 Description
From issue #266: the 2026-09-21 deploy gate read failure/2 while run 35620418784 succeeded at 15:45:07Z and deployed production a1b4db6.
Concurrency cancels queue-mates that never started, so those runs carry no verdict. The gate counted them as consecutive failures anyway, so a healthy deploy archived as broken. A cancelled run now reads through like a skipped one, and cancelled-only history reads as missing instead of failure.
One question for review:
timed_outandstalestill count as verdicts. Both runs started and genuinely failed to report success, so that seemed right, but I have not seen either conclusion on this repo's workflows.