Skip to content

CI gate reads queued cancelled deploys as failures #266

Closed

Description

@harlan-github-agent

completedState walks workflow runs in createdAt order and counts cancelled concurrency queue-mates as consecutive failures, so the 2026-09-21 deploy gate read failure/2 while run 35620418784 succeeded at 15:45:07Z and deployed production a1b4db6.

Target: checks/_helpers/observability.mjs (completedState)

Verify with: pnpm vitest run test/unit/daily-checkin-observability.test.ts

Estimated to change 2 files.

The daily-checkin routine opened this issue automatically on its 2026-09-21T21:40:00.000Z run. It is not Harlan's own report. Close it to reject the proposal, and the reason you give stops it being offered again.

Activity

  1. harlan-github-agent commented on Sep 21, 2026

    @harlan-github-agent
    ContributorAuthor

    🤖 ISSUE TRIAGE

    Harlan Agent Kit posted this automated triage. It is not Harlan's personal assessment or commitment. AI open source policy.

    • Route: Ready to implement
    • Difficulty: 2/5
    • Impact: 3/5
    • Reproduction: Yes
    • Codebase review: Not needed
    • Summary: Confirmed in checks/_helpers/observability.mjs: carriesVerdict (line 78) only excludes 'skipped', so completed runs with conclusion 'cancelled' count as verdicts. completedState (lines 82-97) then counts cancelled concurrency queue-mates as
    • Next action: Update carriesVerdict in checks/_helpers/observability.mjs to also exclude conclusion 'cancelled' (read through like skipped, with a comment citing the 2026-09-21 incident), add a regression test that cancelled queue-mates in front of a success read as success and that cancelled-only history reads missing, then run pnpm vitest run test/unit/daily-checkin-observability.test.ts.
  2. added
    harlan-agent-ready-to-implementIssue triage found bounded work ready for an implementation Agent.
    harlan-agent-runningAn Agent holds a Task on this issue or pull request right now.
    and removed
    harlan-agent-runningAn Agent holds a Task on this issue or pull request right now.
    on Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions