Skip to content

feat(identity): store the device label the CLI sends at sign-in - #242

Merged
harlan-zw merged 1 commit into
mainfrom
feat/cli-device-label
Sep 16, 2026
Merged

feat(identity): store the device label the CLI sends at sign-in#242
harlan-zw merged 1 commit into
mainfrom
feat/cli-device-label

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Related to skilld-dev/skilld#149

❓ Type of change

  • 👌 Enhancement

📚 Description

/me/devices falls back to the token kind when device_label is empty, and the token exchange never accepted a label, so every CLI sign-in showed up as oauth. The endpoint now takes an optional device_label (trimmed, 64 characters max, no control characters) and stores it on the CLI token.

The schema extends the published protocol type locally until skilld-protocol ships the field. This can deploy before or after the CLI change.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw
feat(identity): store the device label the CLI sends at sign-in
3c5be60 
The devices page already shows device_label, but the token exchange never
accepted one, so every CLI sign-in showed only its token kind.
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Sep 16, 2026
@harlan-github-agent

harlan-github-agent Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-09-16 16:09 UTC.

GitHub merged this pull request.

No material findings were recorded.

bc520f39-503c-424c-a740-03b13cf72589

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Sep 16, 2026
@harlan-zw harlan-zw mentioned this pull request Sep 16, 2026
Merged
1 task done
harlan-zw added a commit that referenced this pull request Sep 16, 2026
@harlan-zw
docs(marketing): describe the full privacy stack on /privacy
fd0f563 
The page described the site after #240 and #241 only. #242, #243, #244,
and #246 change CLI token labels, email click counts, like visibility,
repository indexing, and image loading, and D1 recovery keeps deleted rows
for up to 30 days.
@harlan-zw
harlan-zw merged commit b907d91 into main Sep 16, 2026
5 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Sep 16, 2026
harlan-zw added a commit that referenced this pull request Sep 22, 2026
@harlan-zw
docs(marketing): describe the full privacy stack on /privacy
d3d4a1e 
The page described the site after #240 and #241 only. #242, #243, #244,
and #246 change CLI token labels, email click counts, like visibility,
repository indexing, and image loading, and D1 recovery keeps deleted rows
for up to 30 days.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@harlan-zw