Repository navigation
chore(privacy): keep less personal data - #241
Merged
Merged
Conversation
A closed session left a usable GitHub access and refresh token in D1. Star import and repository scan now ask for a new GitHub sign-in when the token is gone.
Ended CLI tokens, sign-in codes, device sessions, and email history were kept forever.
The skilld CLI never sends it, so the column could only hold device details.
An image from any host let a Skill author log visitor IP addresses with a tracking pixel.
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 32387c99-eb1f-44bc-bb93-b76713b75975 |
The authorize page shows it so a person can confirm which machine signs in. This reverts commit 6948d83.
1 task done
1 task done
1 task done
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Privacy audit follow-ups. Each one kept or leaked personal data for no product reason.
users. Sign-out now deletes them. Star import and repository scan in another open session return a 401 that says to sign in with GitHub again. The next GitHub sign-in stores new tokens, so nothing is lost.purge-personal-datatask (shares the 04:30 trigger, so no new Cloudflare cron) deletes:weekly_runsandemail_preference_eventsolder than 90 days. Opt-in state lives onusers, so no reader needs old events. The admin weekly view reads only the last 8 weeks.digest_runsolder than 90 days, except each account's newest sent or skipped run, because that row holds the next digest cursor. Unresolved runs (failed, uncertain, claimed, sending) also stay, since deleting them could cause a duplicate send.raw.githubusercontent.com,user-images,private-user-images,avatars,github.com/<owner>/<repo>/raw/...,github.com/user-attachments/assets/...), withreferrerpolicy="no-referrer"andloading="lazy". Any other image becomes a link, or plain alt text when it already sits in a link.machine_hintstays: the authorize page shows it so a person can confirm which machine signs in.Open questions:
user-attachments/assetsbeyond the audit list, since new GitHub uploads live there.📝 Migration
purge-personal-datasetsactiveFromSecondsto 17 Sep 2026 00:00 UTC. If this deploys after about 18 Sep 12:00 UTC, the daily health check can report one missing run until the first 04:30 run.