Repository navigation
Wk9874/sender exception handling fixz - #878
Merged
kzscisoft merged 3 commits intoOct 13, 2025
Merged
Conversation
kzscisoft
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'throw_exceptions' option to Sender
Python Version(s) Tested: 3.10
Operating System(s): Ubuntu
📝 Summary
Some of the offline mode tests were failing due to
error.args[0]not working with ValidationErrors, changes this to str(error) insteadAlso this gave misleading error messages in the tests- would prefer offline mode tests to throw errors encountered by sender (and more widely, users should also have this choice). So adds
throw_exceptionoption to Sender which will throw exceptions when encountered instead of suppressing and logging (which is default behaviour). Changed all tests to use this🔍 Diagnosis
Failing gridmetrics test
✔️ Checklist