Skip to content

Sender will not raise errors if using thread pool executor #871

Closed

Description

@wk9874

Description of Bug

IF using the thread pool executor within sender, and one of the threads encounters an error, this error will never be thrown. This is because it is stored in _result, and this is never iterated over to extract any errors.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Create a run in offline mode
  2. Create a file
  3. Do run.save_file()
  4. Change the contents of the file
  5. Run sender(threading_threshold=1)

Expected behavior

Error should be thrown due to mismatched checksum (#870 )

Actual Behaviour

No error is thrown

Setup

  • OS: Ubuntu 22.04
  • Python version 3.10

Activity

  1. wk9874 commented on Oct 16, 2025

    @wk9874
    CollaboratorAuthor

    Fixed in #878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingoffline

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions