fix(chat): use native attachment action by BillLeoutsakosvl346 · Pull Request #8265 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T19:58:15Z

Summary

Replace the clickable workflow-chat attachment Badge with an EMCN Button while preserving its 14px icon treatment.
Give the action a native button role, an accessible name, keyboard activation, and a real disabled state when no workflow is selected, execution is active, or the file limit is reached.
Keep the existing hidden file input and upload path.

Validation

Focused chat tests: 6 passed, including picker activation and all three unavailable states.
Biome and whitespace checks passed on the two changed files.
Matched light and dark captures at 16px and 20px root text show identical idle, hover, and disabled pixels. The new visible keyboard focus ring is the only focus-state change.
Browser checks confirm Enter and Space activate the picker callback and disabled activation is blocked.
The app type check passed with worktree-local package links.

The local design diff checker reports five component-chrome overrides on this Button. They preserve its existing 14px box, 6px radius, and zero padding, and add the 1px focus ring. The existing EMCN icon size is 20px; the other 14px actions use different radius, hover, and focus treatments, so these values remain a reviewed Extra. The raw findings remain visible in the external review ledger.

This PR targets the EMCN consolidation branch (#7998).

vercel · 2026-09-24T19:58:21Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 8:04pm UTC

BillLeoutsakosvl346 · 2026-09-24T19:58:26Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T19:58:30Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:58:34Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-24T20:02:05Z

Confidence Score: 5/5

The PR appears safe to merge, with a non-blocking keyboard-focus tooltip regression.

Findings

Keyboard focus loses tooltip ▶

Summary

The PR replaces the workflow-chat attachment badge with a named, natively disabled button and adds tests for picker activation and unavailable states. The follow-up wraps the button in a tooltip trigger so disabled users can still hover for its label.

_{Reviews (2) · Last reviewed commit: "fix(chat): retain disabled attachment to..."}

BillLeoutsakosvl346 · 2026-09-24T20:05:24Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T20:05:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T20:05:38Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-24T20:14:08Z

-                    >
-                      <Paperclip className='h-3.5! w-3.5!' />
-                    </Badge>
+                    <span className='inline-flex'>


Keyboard focus loses tooltip When a keyboard user focuses the enabled attachment button, “Attach file” no longer appears as a tooltip. The tooltip’s focus handler is now attached to the surrounding span and checks whether that span is focused, rather than the button. This makes the action’s label less discoverable for keyboard users.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

* improvement(emcn): share ordinary action geometry in Button * improvement(emcn): consolidate selection controls and styling options * test(emcn): read email geometry from the public export * improvement(emcn): share larger chip and field geometry (#8151) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): use EMCN fields in deployment and setup modals (#8009) * improvement(emcn): share larger chip and field geometry * refactor(ui): use EMCN fields in deployment and setup modals * improvement(ui): reuse chip for PII configuration action (#8173) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): compose horizontal and credential fields in EMCN (#8164) * improvement(ui): compose horizontal and credential fields in EMCN * Share deploy chat field error treatment (#8255) * refactor(ui): share deploy chat field error treatment * refactor(ui): name deploy error props --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): share knowledge filter headings (#8073) * improvement(ui): share knowledge filter headings * improvement(ui): share inline filter and pagination actions (#8163) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): use chip fields in workflow search and replace (#8076) * improvement(emcn): share larger chip and field geometry * improvement(ui): use chip fields in workflow search and replace * fix(ui): use shared centered chip content on chat errors * improvement(ui): use chips for ordinary product actions (#8081) * improvement(ui): use chips for ordinary product actions * improvement(ui): use shared chip alignment * improvement(ui): use shared search action sizes (#8160) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): reuse chips for custom block upload actions (#8084) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(chat): use native attachment action (#8265) * fix(chat): use native attachment action * fix(chat): retain disabled attachment tooltip --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(chat): use EMCN icon button target for attachments * refactor(ui): centralize destructive ghost button colors in EMCN (#7988) * improvement(emcn): share larger chip and field geometry * refactor(ui): use EMCN fields in deployment and setup modals * refactor(ui): centralize destructive ghost button colors in EMCN * improvement(ui): use standard knowledge tag icon size * refactor(ui): consolidate product corner radii * improvement(ui): reuse chip for PII configuration action (#8173) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share collapsible workflow field cards (#8017) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): compose horizontal and credential fields in EMCN (#8164) * improvement(ui): compose horizontal and credential fields in EMCN * Share deploy chat field error treatment (#8255) * refactor(ui): share deploy chat field error treatment * refactor(ui): name deploy error props --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): share public headings and product typography (#8069) * improvement(emcn): share larger chip and field geometry * improvement(ui): share public authentication headings * improvement(ui): share workflow panel tab buttons (#8072) * improvement(ui): share workflow panel tab buttons * improvement(ui): reuse chips for panel selection actions (#8166) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share account headings and auth control sizing (#8074) * improvement(ui): share account status headings * improvement(ui): use shared sizing for auth controls * refactor(emcn): share invalid OTP slot treatment (#8246) * Add shared invalid state to EMCN OTP slots * fix(ui): distinguish OTP verification from resend errors * test(ui): type OTP input queries as inputs * test(ui): import OTP test button prop type * test(ui): use shared logger mock in OTP regression --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): share missing resource states (#8078) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): reuse avatars for owners and members (#8079) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): adopt exact shared 18px typography token * fix(ui): preserve panel and auth control semantics --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * fix(ui): preserve shared tag actions and product styling fallbacks * fix(ui): keep logs filters on canonical chip height --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Codex <codex@openai.com> Co-authored-by: Waleed <walif6@gmail.com>

fix(chat): use native attachment action

b11464d

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/chat.tsx Outdated

Comment thread apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/chat.tsx Outdated

fix(chat): retain disabled attachment tooltip

f0bff33

vercel Bot temporarily deployed to Preview September 24, 2026 20:04 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit 0059be1 into codex/emcn-consolidation Sep 24, 2026
5 checks passed

waleedlatif1 deleted the codex/emcn-next-attachment-action branch September 24, 2026 23:58

Navigation Menu

Repository navigation

fix(chat): use native attachment action - #8265

fix(chat): use native attachment action#8265
BillLeoutsakosvl346 merged 2 commits into
codex/emcn-consolidationfrom
codex/emcn-next-attachment-action

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

vercel Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

greptile-apps Bot Sep 24, 2026

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026

Summary

Validation

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Findings

Summary

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading