improvement(ui): reuse chips for custom block upload actions by BillLeoutsakosvl346 · Pull Request #8084 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-21T00:58:24Z

Summary

Use the existing outlined Chip for custom-block Upload/Change and the icon Button for Remove.
Center the actions beside the preview and preserve upload callbacks, accepted file types, loading states and permission guards.

Type of Change

Refactor / maintainability improvement

Testing

All workspace type checks, repository lint, audits (including import and API validation), and generated-artifact checks pass.
Complete EMCN suite and relevant existing consumer tests pass.
Existing real-component browser fixtures cover both themes, narrow layouts, enlarged text, disabled states and local upload/change/remove callbacks. These do not exercise the live upload service.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-21T00:58:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 22, 2026 9:10pm UTC

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-21T01:00:37Z

Confidence Score: 5/5

The PR appears safe to merge because there are no accepted new findings and the sole previous thread was manually resolved.

Summary

The PR updates the custom-block icon controls to reuse the outlined Chip for Upload/Change and an icon-only ghost Button for Remove while retaining the existing callbacks, disabled states, and permission guards.

Replaces the small outlined upload button with the shared Chip.
Centers the action controls alongside the preview.
Simplifies the Remove action’s styling and geometry.

_{Reviews (5) · Last reviewed commit: "improvement(ui): reuse chips for custom ..."}

BillLeoutsakosvl346 · 2026-09-21T01:09:17Z

@greptile

BillLeoutsakosvl346 · 2026-09-21T01:09:18Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-21T01:09:23Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T04:17:05Z

@greptile

BillLeoutsakosvl346 · 2026-09-21T04:17:06Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-21T04:17:13Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 1 file

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T17:59:32Z

Before / after visual comparison

Custom-block Upload/Change actions use the shared outline Button. The border becomes the canonical outline color; the icon tile and upload interaction remain.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Only the retained upload-action change is shown. The earlier resource-picker migration was withdrawn.

Current PR head checked at posting: cde590ada0.

Additional theme/state comparisons

BillLeoutsakosvl346 · 2026-09-22T21:10:23Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T21:10:24Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T21:10:35Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 1 file

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-22T21:15:25Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T21:15:26Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T21:15:32Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 1 file

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

* improvement(emcn): share ordinary action geometry in Button * improvement(emcn): consolidate selection controls and styling options * test(emcn): read email geometry from the public export * improvement(emcn): share larger chip and field geometry (#8151) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): use EMCN fields in deployment and setup modals (#8009) * improvement(emcn): share larger chip and field geometry * refactor(ui): use EMCN fields in deployment and setup modals * improvement(ui): reuse chip for PII configuration action (#8173) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): compose horizontal and credential fields in EMCN (#8164) * improvement(ui): compose horizontal and credential fields in EMCN * Share deploy chat field error treatment (#8255) * refactor(ui): share deploy chat field error treatment * refactor(ui): name deploy error props --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): share knowledge filter headings (#8073) * improvement(ui): share knowledge filter headings * improvement(ui): share inline filter and pagination actions (#8163) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): use chip fields in workflow search and replace (#8076) * improvement(emcn): share larger chip and field geometry * improvement(ui): use chip fields in workflow search and replace * fix(ui): use shared centered chip content on chat errors * improvement(ui): use chips for ordinary product actions (#8081) * improvement(ui): use chips for ordinary product actions * improvement(ui): use shared chip alignment * improvement(ui): use shared search action sizes (#8160) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): reuse chips for custom block upload actions (#8084) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(chat): use native attachment action (#8265) * fix(chat): use native attachment action * fix(chat): retain disabled attachment tooltip --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(chat): use EMCN icon button target for attachments * refactor(ui): centralize destructive ghost button colors in EMCN (#7988) * improvement(emcn): share larger chip and field geometry * refactor(ui): use EMCN fields in deployment and setup modals * refactor(ui): centralize destructive ghost button colors in EMCN * improvement(ui): use standard knowledge tag icon size * refactor(ui): consolidate product corner radii * improvement(ui): reuse chip for PII configuration action (#8173) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share collapsible workflow field cards (#8017) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): compose horizontal and credential fields in EMCN (#8164) * improvement(ui): compose horizontal and credential fields in EMCN * Share deploy chat field error treatment (#8255) * refactor(ui): share deploy chat field error treatment * refactor(ui): name deploy error props --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): share public headings and product typography (#8069) * improvement(emcn): share larger chip and field geometry * improvement(ui): share public authentication headings * improvement(ui): share workflow panel tab buttons (#8072) * improvement(ui): share workflow panel tab buttons * improvement(ui): reuse chips for panel selection actions (#8166) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share account headings and auth control sizing (#8074) * improvement(ui): share account status headings * improvement(ui): use shared sizing for auth controls * refactor(emcn): share invalid OTP slot treatment (#8246) * Add shared invalid state to EMCN OTP slots * fix(ui): distinguish OTP verification from resend errors * test(ui): type OTP input queries as inputs * test(ui): import OTP test button prop type * test(ui): use shared logger mock in OTP regression --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): share missing resource states (#8078) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): reuse avatars for owners and members (#8079) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): adopt exact shared 18px typography token * fix(ui): preserve panel and auth control semantics --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * fix(ui): preserve shared tag actions and product styling fallbacks * fix(ui): keep logs filters on canonical chip height --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Codex <codex@openai.com> Co-authored-by: Waleed <walif6@gmail.com>

vercel Bot temporarily deployed to Preview September 21, 2026 00:58 Inactive

cubic-dev-ai Bot reviewed Sep 21, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview September 21, 2026 01:09 Inactive

cubic-dev-ai Bot reviewed Sep 21, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview September 21, 2026 03:31 Inactive

BillLeoutsakosvl346 changed the title ~~improvement(ui): reuse chip comboboxes for workflow resources~~ improvement(ui): reuse chips for custom block upload actions Sep 21, 2026

vercel Bot temporarily deployed to Preview September 21, 2026 04:17 Inactive

cubic-dev-ai Bot reviewed Sep 21, 2026

View reviewed changes

BillLeoutsakosvl346 force-pushed the codex/emcn-consolidation branch from bf036a1 to a8070bc Compare September 22, 2026 19:41

improvement(ui): reuse chips for custom block upload actions

837874f

BillLeoutsakosvl346 force-pushed the codex/control-fix-resource-comboboxes branch from cde590a to 837874f Compare September 22, 2026 21:10

vercel Bot temporarily deployed to Preview September 22, 2026 21:10 Inactive

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread apps/sim/ee/custom-blocks/components/custom-block-detail.tsx

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit 91dedb0 into codex/emcn-consolidation Sep 24, 2026
5 checks passed

waleedlatif1 deleted the codex/control-fix-resource-comboboxes branch September 24, 2026 23:57

Conversation

BillLeoutsakosvl346 commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Before / after visual comparison

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillLeoutsakosvl346 commented Sep 21, 2026 •

edited

Loading

vercel Bot commented Sep 21, 2026 •

edited

Loading

greptile-apps Bot commented Sep 21, 2026 •

edited

Loading