Repository navigation
check-pr on a plan PR doesn't seed its checkout - #119
Merged
Merged
Conversation
check-pr validates a plan PR's head in a detached worktree. Since sibling repos (#108) that worktree was seeded like a worker's: worktree_files copied and worktree_setup run. A CI runner has neither the project's toolchain nor its untracked files, so every plan PR's check-pr failed in CI (Stacks: "worktree_setup failed", bundle install with no Ruby). It only reads the plan and the log: the checkout is no longer seeded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s apply as on main) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
devteam.mjs:detachedWorktreetakes{ seed }. check-pr's plan path (validate --strictat the head) usesseed: false, so it copies noworktree_filesand runs noworktree_setup. Merge's gate worktrees and goal measure readings still seed, because they run the project's commands.worktree_setupset to a failing command andworktree_filesnaming a missing file.Why
Since #100 and #108, the plan check's throwaway worktree was seeded like a worker's. In CI there's no toolchain and no untracked files, so every plan PR's check-pr failed. Stacks hit it: plan PR #428 got "worktree_setup failed" because
bundle installhad no Ruby on the runner, so every Stacks plan PR was blocked. The check only reads the plan and the log.Migration
None.
🤖 Generated with Claude Code