Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Remote environment support - #551

Merged
wingrunr21 merged 33 commits into
masterfrom
remove_environment_support
Nov 19, 2019
Merged

wingrunr21 merged 33 commits into
masterfrom
remove_environment_support

Conversation

@wingrunr21

@wingrunr21 wingrunr21 commented Oct 19, 2019 •

Copy link
Copy Markdown
Collaborator

@wingrunr21
wingrunr21 force-pushed the remove_environment_support branch from 1f3efe6 to a541b0d Compare October 19, 2019 17:07
@codecov

codecov Bot commented Oct 19, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #551 into master will increase coverage by 0.35%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
+ Coverage    34.1%   34.46%   +0.35%     
==========================================
  Files          11       11              
  Lines         173      177       +4     
  Branches       38       38              
==========================================
+ Hits           59       61       +2     
- Misses        109      111       +2     
  Partials        5        5
Flag Coverage Δ
#language_server_ruby 5.3% <0%> (ø) ⬆️
#vscode_ruby_common 85.93% <50%> (-2.4%) ⬇️
Impacted Files Coverage Δ
packages/language-server-ruby/src/Formatter.ts 0% <ø> (ø) ⬆️
packages/language-server-ruby/src/Linter.ts 0% <0%> (ø) ⬆️
packages/vscode-ruby-common/src/environment.ts 85.93% <50%> (-2.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d6435...71ddf06. Read the comment docs.

@wingrunr21
wingrunr21 force-pushed the remove_environment_support branch from a541b0d to 32dbf1d Compare October 20, 2019 13:28
@wingrunr21 wingrunr21 changed the title Remove environment support Remote environment support Oct 20, 2019
@wingrunr21
wingrunr21 marked this pull request as ready for review November 19, 2019 18:02
@wingrunr21
wingrunr21 merged commit dcfbb84 into master Nov 19, 2019
@wingrunr21
wingrunr21 deleted the remove_environment_support branch November 19, 2019 18:05
@connorshea

Copy link
Copy Markdown
Contributor

❤️ thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support fish shell in environment detection Flag machine specific configurations like paths as machine scoped Move environment detection to server

2 participants