This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted #483
Description
Your environment
vscode-rubyversion: 0.22.3- Ruby version: 2.6.3
- Ruby version manager (if any): rbenv
- VS Code version: 1.34.10-insider
- Operating System: Windows
- Using language server? Solargraph
- Using via "Remote - SSH" remote environment (Link)
Expected behavior
Symbol strings syntax is correctly highlighted
Actual behavior
Symbol strings syntax is incorrectly highlighted
In the picture below :exception should be highlighted
Activity
connorshea commentedon May 12, 2019
I assume this is the same problem as microsoft/vscode-remote-release#153
danglduy commentedon May 13, 2019
I think these are not the same problems. Ruby symbols are correctly highlighted without any language servers anyway.
minkir014 commentedon May 13, 2019
Have you tried that on an ordinary vs code?
danglduy commentedon May 13, 2019
@minkir014 "Remote - SSH" extension does only work on VS Code Insider I'm afraid.
wingrunr21 commentedon May 13, 2019
hi @danglduy
Can you use the
Developer: Inspect TM Scopestool (accessible via the command palette) to tell me what scopes are being matched for thewith: :exceptionpart of that code?The
with:should be matching the grammar with a scope ofconstant.language.symbol.hashkey.rubyand:exceptionshould beconstant.language.symbol.ruby.danglduy commentedon May 13, 2019
@wingrunr21 I inspected
with:and:exceptionwingrunr21 commentedon May 13, 2019
Ok. What theme are you using? The Ruby grammar is correctly matching the TM scopes but it appears your theme does not have support.
danglduy commentedon May 13, 2019
@wingrunr21 I am using the default theme.
wingrunr21 commentedon May 13, 2019
Which is that?
Dark+?danglduy commentedon May 13, 2019
Yes it’s Dark+
wingrunr21 commentedon May 14, 2019
interesting. I also use Dark+ and I get those keywords highlighted in blue. Do you get highlighting with a different theme?
danglduy commentedon May 14, 2019
@wingrunr Have you tried using in “Remote SSH” environment? I get highlighted normally in local environment.
wingrunr21 commentedon May 14, 2019
No but that's what I'm trying to determine what the problem is. Does another theme give you correct highlighting?
The Remote SSH environment isn't stable yet and this extension doesn't explicitly support it. Theming is a core VSCode function as well. The grammar is supplying and matching a TM Scope but the theme doesn't have a matching style.
OmriSama commentedon Jul 16, 2019
Following
OmriSama commentedon Jul 18, 2019
Here's the difference between correctly working TM scope and a not correctly working one:
CORRECT
INCORRECT
Issue is in
constant.languagevsconstant.other.symbolminkir014 commentedon Jul 18, 2019
How have you displayed this in vscode insiders??? I mean what is displayed in the images.
OmriSama commentedon Jul 18, 2019
I opened the same directory in two windows, one was local VSCode and another one was Remote SSH.
connorshea commentedon Jul 18, 2019
There's a command in the command palette called "Inspect TM Scopes", I think that's what they're asking for.
wingrunr21 commentedon Jul 18, 2019
That's what it is. I'm digging into Remote environments after I fix the current issue with
tree-sitter. I haven't yet researched why VSCode is assigning different TextMate scopes between the two environments.OmriSama commentedon Jul 27, 2019
Any updates on this?
wingrunr21 commentedon Nov 19, 2019
This has been resolved in
v0.26.0OmriSama commentedon Nov 19, 2019
@wingrunr21 thank you so much! This has been sorely lacking in my Ruby experience :)