This repository was archived by the owner on Nov 9, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 9, 2022. It is now read-only.
NodeMainExecutorService leaks RosActivity through NodeMainExecutorServiceListener #254
Description
When a RosActivity is destroyed, and the main application is still running, the NodeMainExecutorService contains a reference to the RosActivity preventing it from gc. The fix is to add the ability to remove the NodeMainExecutorServiceListener created in the RosActivity from the NodeMainExecutorService ListenerGroup. This requires ListenerGroup to contain a method for removing a listener (bug filed in rosjava/rosjava_core rosjava/rosjava_core#233).
Activity
Fixed NodeMainExecutorService and added dependency of fixed rosjava_c…
jubeira commentedon Mar 14, 2017
This was fixed for Indigo but not for Kinetic yet, am I right?
stratomda commentedon Mar 14, 2017
That seems to be correct.
adamantivm commentedon Mar 14, 2017
That was my fault, I screwed something up when I tried to do the update - I got the 0.3.2 to release but failed to push upstream from my local copy. It should be fixed now, but I'd appreciate a second pair of eyes.
jubeira commentedon Mar 14, 2017
LGTM; I think this issue can be closed now.
stratomda commentedon Apr 17, 2017
@adamantivm is this issue still open or was it merged into 0.3.3?
adamantivm commentedon Apr 18, 2017
It's merged and published!