This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 11, 2023. It is now read-only.
ListenerGroup.shutdown() never called #233
Description
The ListenerGroup.shutdown() method is never called when cleaning up the DefaultNode class. I believe that this is causing a memory leak issue with android_core when trying to shutdown objects that extend NodeMain. See: http://answers.ros.org/question/255722/rosjava-listenergroup-causes-android-memory-leak/
Activity
adamantivm commentedon Mar 1, 2017
Thanks for the report @stratomda . I'll try to dig into it when I can get a chance. If you get to it before I do, by all means please submit a PR.
Meanwhile, I'll leave the link to your test code here.
stratomda commentedon Mar 2, 2017
@adamantivm I think I have a fix for this. I have started testing it and should be done in the next few days. This same issue might also be present in android_core under the NodeMainExecutorService class. I will investigate that as well. Wanted to make sure we both aren't working on the same thing.
adamantivm commentedon Mar 3, 2017
@stratomda thanks very much for the work and for the heads-up. I haven't been able to carve out time to look into this so your pro-activity is appreciated. I'll check here before starting if I don't hear anything else by the time I do get time (not real soon).
This closes rosjava#233. Adds fix for shutting down DefaultNodeMainEx…
Merge pull request #234 from stratomda/indigo