Skip to content

Add support for parent element for ElementFinder and TableElementFinder to support normal locator strategies - #921

Merged
pekkaklarck merged 6 commits into
robotframework:masterfrom
aaltat:element_finder_to_support_parent_webelement
Sep 27, 2017
Merged

pekkaklarck merged 6 commits into
robotframework:masterfrom
aaltat:element_finder_to_support_parent_webelement

Conversation

@aaltat

@aaltat aaltat commented Sep 26, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@aaltat aaltat changed the title Make element finder support parent element Add support for parent element for ElementFinder and TableElementFinder to support normal locator strategies Sep 26, 2017
@aaltat

aaltat commented Sep 26, 2017 •

Copy link
Copy Markdown
Contributor Author

Things to do:

  • Write better test in test_tableelementfinder.py test
  • Make acceptance test to use newly supported locators like id, name and so on.

@pekkaklarck

Copy link
Copy Markdown
Member

Test also new strategy:value syntax.

@aaltat

aaltat commented Sep 26, 2017

Copy link
Copy Markdown
Contributor Author

The table element keyword are now done. I will fix the library documentation in separate PR.

@aaltat

aaltat commented Sep 26, 2017

Copy link
Copy Markdown
Contributor Author

This fixes #923

@pekkaklarck
pekkaklarck merged commit d85233a into robotframework:master Sep 27, 2017
@pekkaklarck

Copy link
Copy Markdown
Member

So much better than it used to be! More functionality with less code (+281 additions, −293 removals) is always nice.

@aaltat
aaltat deleted the element_finder_to_support_parent_webelement branch October 30, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants