Skip to content

Update all plays that needed to have the .jsx extenstion to work with… - #1103

Closed
Angra974 wants to merge 4 commits into
mainfrom
1100-bug-report-all-plays-are-not-usable-with-wi
Closed

Angra974 wants to merge 4 commits into
mainfrom
1100-bug-report-all-plays-are-not-usable-with-wi

Conversation

@Angra974

@Angra974 Angra974 commented Apr 9, 2023

Copy link
Copy Markdown
Contributor

… vite.

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

ViteJs need a .jsx extension to load react file. The react plays are create with .js extension. So, they won't be able to be used with Vite for people who don't want to use CRA. CRA can load the .jsx file without problem, so it's safe to make the change as it will not impact the current CRA build and will not stop people to migrate their project to Cra => vite without having problems with the plays.

Fixes # (issue)
Be able to use all the plays with viteJs

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cloned the last version of Cra-Reactplay yesterday.
Got all the plays in a ViteJs-Reactplay build and make correction file by file following the error given by ViteJs for each file.
Some plays need a minimum of rewrite but did not impact the owner code as it's some little mistakes allowed to be functional with Cra but not with vite.

When all the plays were able to be loaded in my ViteJs-Reactplay,
i've copied the full plays folder back in the Cra-version and tested all the plays, one by one to be certain that all of them load as expected.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have tested the necessary stuff ( play by play) that proves my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@Angra974 Angra974 linked an issue Apr 9, 2023 that may be closed by this pull request
1 task done
@vercel

vercel Bot commented Apr 9, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 5:22am

@atapas
atapas requested a review from koustov April 10, 2023 02:40
koustov
koustov previously approved these changes Apr 11, 2023

@koustov koustov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

As index.js is ignored from the push. Reason why I didn't see it.
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 11, 2023
@github-actions github-actions Bot closed this May 18, 2023
@priyankarpal
priyankarpal deleted the 1100-bug-report-all-plays-are-not-usable-with-wi branch October 16, 2023 18:48

This branch was successfully deployed

1 active deployment
Preview — 22b2948e Deployed Apr 11, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: All plays are not usable with Wi

2 participants