Repository navigation
Conversation
1 task done
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
As index.js is ignored from the push. Reason why I didn't see it.
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions! |
priyankarpal
deleted the
1100-bug-report-all-plays-are-not-usable-with-wi
branch
October 16, 2023 18:48
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… vite.
Description
ViteJs need a .jsx extension to load react file. The react plays are create with .js extension. So, they won't be able to be used with Vite for people who don't want to use CRA. CRA can load the .jsx file without problem, so it's safe to make the change as it will not impact the current CRA build and will not stop people to migrate their project to Cra => vite without having problems with the plays.
Fixes # (issue)
Be able to use all the plays with viteJs
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Cloned the last version of Cra-Reactplay yesterday.
Got all the plays in a ViteJs-Reactplay build and make correction file by file following the error given by ViteJs for each file.
Some plays need a minimum of rewrite but did not impact the owner code as it's some little mistakes allowed to be functional with Cra but not with vite.
When all the plays were able to be loaded in my ViteJs-Reactplay,
i've copied the full plays folder back in the Cra-version and tested all the plays, one by one to be certain that all of them load as expected.
Checklist:
Screenshots or example output