Skip to content

🐛 [Bug report]: All plays are not usable with Wi #1100

Closed as not planned
Closed as not planned

Description

@Angra974

Descrcibe the bug?

When using React-Play with Vite-Js, some plays won't work because Vite doesn't let file with mixed react content with javascript if the file doesn't have the jsx extension or the tsx extension.
The extension jsx/tsx won't have a problem with Cra.
So, it's save to move all plays to jsx/tsx extension.

For the future, it will be good that create-react-play create the play with jsx/tsx extension to not have this problem again.

Steps to reproduce the bug?

Move from Cra to Vite.

A little discussion about it here :
https://twitter.com/youyuxi/status/1362050255009816577

Expected behavior

Just change the extension for the js file that uses react inside.
For other files with the js extension but without react code inside, let them with the js extension.

Nevertheless, the random-quote-card-generator play needs a little rewrite as a default export is not named correctly
and won't be accepted by vite with a bad import.
It doesn't impact the play and the personal code of the creator.

Desktop (Please provide your system information)

Not relevant.

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

image

Relevant log output

No

Code of Conduct

  • I agree to follow this project's Code of Conduct

Activity

  1. github-actions commented on Apr 8, 2023

    @github-actions

    Hey! contributor, thank you for opening an Issue 🎉.

    @reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
    Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
    Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

  2. github-actions commented on May 10, 2023

    @github-actions

    There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

  3. reopened this on Sep 7, 2023
  4. github-actions commented on Oct 8, 2023

    @github-actions

    There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingstale

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions