Skip to content

Test failures on Mac OS X #121

Closed
Closed
Test failures on Mac OS X#121
Labels
bughelp wantedmaintenance
Milestone
v0.8.5

Description

@andig
andig
opened on Oct 7, 2017

Not really an issue, more fyi:

There were 3 failures:

1) React\Tests\Socket\FunctionalSecureServerTest::testEmitsErrorIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) React\Tests\Socket\FunctionalTcpServerTest::testEmitsConnectionEvenIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) React\Tests\Socket\UnixConnectorTest::testValid
Failed asserting that Binary String: 0x756e69783a2f2f000000000000000000000000000000 is null.

/Users/andig/Documents/htdocs/react-socket/tests/UnixConnectorTest.php:62

Activity

  1. clue
    added
    bug
    help wanted
    on Oct 7, 2017
  2. clue
    changed the title [-]Test failures on OSX[/-] [+]Test failures on Mac OS X[/+] on Oct 7, 2017
  3. clue
    added
    easy pick
    on Oct 7, 2017

  4. clue commented on Oct 7, 2017

    @clue
    clue
    on Oct 7, 2017
    Member

    Thanks for reporting! Can anybody else with Mac OS X confirm these issues? Also, PRs would be welcome! :shipit:

  5. WyriHaximus commented on Oct 7, 2017

    @WyriHaximus
    WyriHaximus
    on Oct 7, 2017
    Member

    @clue travis supports running the tests on OS X, but IIRC it's a bit of work to get it working: https://docs.travis-ci.com/user/reference/osx/

  6. jsor commented on Oct 7, 2017

    @jsor
    jsor
    on Oct 7, 2017
    Member

    I can confirm (latest master including #123):

    1) React\Tests\Socket\FunctionalSecureServerTest::testEmitsErrorIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) React\Tests\Socket\FunctionalTcpServerTest::testEmitsConnectionEvenIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

  7. andig commented on Oct 9, 2017

    @andig
    andig
    on Oct 9, 2017
    ContributorAuthor
    1. only fails sometimes (OSX HighSierra)
    2. only fails sometimes (OSX HighSierra)
    3. is fixed by Work around Unix domain socket (UDS) paths for Mac OS X #123
    ~/htdocs/react-socket master ⇡ 6s
❯ repeat 10 phpunit tests/FunctionalTcpServerTest.php             

.................                                                 17 / 17 (100%)
Time: 1.64 seconds, Memory: 12.00MB
OK (17 tests, 31 assertions)

........F........                                                 17 / 17 (100%)
Time: 1.62 seconds, Memory: 12.00MB
There was 1 failure:
1) React\Tests\Socket\FunctionalTcpServerTest::testEmitsConnectionEvenIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.
Tests: 17, Assertions: 30, Failures: 1.

.................                                                 17 / 17 (100%)
Time: 1.66 seconds, Memory: 12.00MB
OK (17 tests, 31 assertions)

.................                                                 17 / 17 (100%)
Time: 1.62 seconds, Memory: 12.00MB
OK (17 tests, 31 assertions)

........F........                                                 17 / 17 (100%)
Time: 1.62 seconds, Memory: 12.00MB
There was 1 failure:
1) React\Tests\Socket\FunctionalTcpServerTest::testEmitsConnectionEvenIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.
Tests: 17, Assertions: 30, Failures: 1.

.................                                                 17 / 17 (100%)
Time: 1.61 seconds, Memory: 12.00MB
OK (17 tests, 31 assertions)

.................                                                 17 / 17 (100%)
Time: 1.62 seconds, Memory: 12.00MB
OK (17 tests, 31 assertions)

........F........                                                 17 / 17 (100%)
Time: 1.6 seconds, Memory: 12.00MB
There was 1 failure:
1) React\Tests\Socket\FunctionalTcpServerTest::testEmitsConnectionEvenIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.
Tests: 17, Assertions: 30, Failures: 1.

........F........                                                 17 / 17 (100%)
Time: 1.65 seconds, Memory: 12.00MB
There was 1 failure:
1) React\Tests\Socket\FunctionalTcpServerTest::testEmitsConnectionEvenIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.
Tests: 17, Assertions: 30, Failures: 1.

........F........                                                 17 / 17 (100%)
Time: 1.6 seconds, Memory: 12.00MB
There was 1 failure:
1) React\Tests\Socket\FunctionalTcpServerTest::testEmitsConnectionEvenIfConnectionIsCancelled
Expectation failed for method name is equal to <string:__invoke> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.
Tests: 17, Assertions: 30, Failures: 1.

    Is it possible that 1 and 2 are somehow none-deterministic?

  8. andig commented on Oct 9, 2017

    @andig
    andig
    on Oct 9, 2017
    ContributorAuthor

    I've checked if the underlying stream may be the culprit and found reactphp/stream#111 but it seems unrelated.

  9. WyriHaximus commented on Oct 9, 2017

    @WyriHaximus
    WyriHaximus
    on Oct 9, 2017
    Member

    @andig does it still fail sometimes within the same run when using --repeat 100 with phpunit

  10. andig commented on Oct 9, 2017

    @andig
    andig
    on Oct 9, 2017
    ContributorAuthor

    After failing once the tests get stuck for good on my slowish machine:

    ❯ phpunit --repeat 100 tests/TcpConnectorTest.php
PHPUnit 5.5.4 by Sebastian Bergmann and contributors.

..........I...........I...........I...........I...........I..   61 / 1200 (  5%)
.........I...........I...........I...........I...........I...  122 / 1200 ( 10%)
........I...........I...........I...........I...........I....  183 / 1200 ( 15%)
.......I...........I...........I...........I...........I.....  244 / 1200 ( 20%)
E.....I.

    or

    ❯ phpunit --repeat 100 tests/TcpConnectorTest.php
PHPUnit 5.5.4 by Sebastian Bergmann and contributors.

..........I...........I...........I...........I...........I..   61 / 1200 (  5%)
.........I...........I...........I...........I...........I...  122 / 1200 ( 10%)
........I...........I...........I...........I...........I....  183 / 1200 ( 15%)
.......I...........I...........I...........I...........I.....  244 / 1200 ( 20%)
......I...........I...........I...........I....EE.....I.
  11. clue
    added
    maintenance
    and removed
    easy pick
    on Oct 10, 2017

  12. clue commented on Oct 13, 2017

    @clue
    clue
    on Oct 13, 2017
    Member

    For the reference: Can anybody run the test suite on Windows and confirm that this is a Mac issue only?

  13. clue
    added this to the v0.8.5 milestone on Oct 13, 2017

  14. WyriHaximus commented on Oct 13, 2017

    @WyriHaximus
    WyriHaximus
    on Oct 13, 2017
    Member

    @clue on windows it hangs on TcpConnectorTest::connectionToEmptyPortShouldFail'

  15. WyriHaximus
    closed this as completedin #130on Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bughelp wantedmaintenance

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions