Skip to content

Test failures on OSX #111

Description

@andig
~/htdocs/react-stream master
❯ phpunit
PHPUnit 5.5.4 by Sebastian Bergmann and contributors.

............SSS.SSS.SSS.SSS.SSS.SSS.SSSFSSS.SSS.SSS............  63 / 154 ( 40%)
............................................................... 126 / 154 ( 81%)
...........................S                                    154 / 154 (100%)

Time: 3.6 seconds, Memory: 69.23MB

There was 1 failure:

1) React\Tests\Stream\DuplexResourceStreamIntegrationTest::testReadsMultipleChunksFromProcessPipe with data set #0 (Closure Object (...), Closure Object (...))
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'abc'
+'-n a
+-n b
+-n c
+'

/Users/andig/Documents/htdocs/react-stream/tests/DuplexResourceStreamIntegrationTest.php:263

FAILURES!
Tests: 154, Assertions: 228, Failures: 1, Skipped: 31.

Activity

  1. cboden commented on Oct 9, 2017

    @cboden
    Member

    Can confirm same results on macOS 10.12.6 w/ PHP v5.6.30

  2. andig commented on Oct 9, 2017

    @andig
    ContributorAuthor

    I will add osx travis coverage once it has been merged in socket to reproduce the final setup.

  3. clue commented on Oct 9, 2017

    @clue
    Member

    The above test basically means that executing echo -n test will actually echo -n test for Mac OS X while the test assumes -n is interpreted as an option flag. Let me look into this :shipit:

  4. added this to the v0.7.4 milestone on Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions