You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently load Babel via CDN (which is nice) but we load it in the <head> of the page (which is not so nice). We should only load it on pages that actually use it (eg pages that use the CodeEditor).
Worker is totally not necessary (but a nice touch). I built a non-worker based version for Babel REPL initially. (It's there in the Git history if you're curious.)
Okay. I've tagged this as "in-progress" then. Please let me know if you decide not to submit a PR and I'll remove that label so someone else can claim the task.
Could be pretty cool to just-in-time load Algolia too, yeah. 😄
I plan to remove it in favor of a client-side search solution like js-worker-search at some point in the future so I hadn't considered it much. That being said, it might take me a long time to get to that so...
Activity
renanpvaz commentedon Oct 6, 2017
Is it necessary to use a worker or could it be achieved through XHR + eval?
bvaughn commentedon Oct 6, 2017
Worker is totally not necessary (but a nice touch). I built a non-worker based version for Babel REPL initially. (It's there in the Git history if you're curious.)
renanpvaz commentedon Oct 6, 2017
Okay, I'll look into it and then attempt to fix the issue.
bvaughn commentedon Oct 6, 2017
Okay. I've tagged this as "in-progress" then. Please let me know if you decide not to submit a PR and I'll remove that label so someone else can claim the task.
renanpvaz commentedon Oct 9, 2017
@bvaughn should
docsearchbe loaded the same way?bvaughn commentedon Oct 9, 2017
Could be pretty cool to just-in-time load Algolia too, yeah. 😄
I plan to remove it in favor of a client-side search solution like js-worker-search at some point in the future so I hadn't considered it much. That being said, it might take me a long time to get to that so...
bvaughn commentedon Oct 9, 2017
Check out issue #98 for my thoughts on that if you're interested
Merge pull request #2 from alexkrolick/render-props-patch-2
Merge pull request #2 from alexkrolick/create-ref-patch-2
Added page translation: basics -> hello world (reactjs#2)
Update 2019-08-15-new-react-devtools.md (reactjs#331)
[Beta] Added documentation for React.createFactory (#5120)
add reactjs#2 line Darko