Skip to content

[Beta] Added documentation for React.createFactory - #5120

Merged
gaearon merged 6 commits into
reactjs:mainfrom
arati-1:api-createFactory
Oct 4, 2022
Merged

gaearon merged 6 commits into
reactjs:mainfrom
arati-1:api-createFactory

Conversation

@arati-1

@arati-1 arati-1 commented Sep 26, 2022

Copy link
Copy Markdown
Collaborator

Added documentation for React.createFactory

@github-actions

github-actions Bot commented Sep 26, 2022 •

Copy link
Copy Markdown

Size Changes

Details

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 88.35 KB (🟡 +53 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 42.99 KB (🟡 +52 B) 131.34 KB
/500 42.97 KB (🟡 +52 B) 131.32 KB
/[[...markdownPath]] 43.05 KB (🟡 +52 B) 131.4 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@arati-1
arati-1 requested a review from gaearon September 26, 2022 18:52
Comment thread beta/src/content/apis/react/createFactory.md Outdated
Comment thread beta/src/content/apis/react/createFactory.md Outdated

@shanpriyan shanpriyan left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error from Sandpack console
image

Comment thread beta/src/content/apis/react/createFactory.md Outdated
Comment thread beta/src/content/apis/react/createFactory.md Outdated
Comment thread beta/src/content/apis/react/createFactory.md Outdated
@gaearon
gaearon force-pushed the api-createFactory branch from 742f18c to 1f1ad43 Compare October 4, 2022 04:07

This branch was successfully deployed

2 active deployments
Preview – reactjs-org — dc427990 Deployed Oct 4, 2022 by vercel[bot]
Preview – beta-reactjs-org — dc427990 Deployed Oct 4, 2022 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants