Skip to content

Translate more page to Persian - #127

Closed
BaseMax wants to merge 22 commits into
reactjs:masterfrom
MaxFork:master
Closed

BaseMax wants to merge 22 commits into
reactjs:masterfrom
MaxFork:master

Conversation

@BaseMax

@BaseMax BaseMax commented Jan 18, 2020 •

Copy link
Copy Markdown

Hello,

Thank you for your help @sorousht. #105

Pages until now:

  • fragments.md
  • reference-react-dom.md
  • forwarding-refs.md (incomplete)

Best,
Max Base

@netlify

netlify Bot commented Jan 18, 2020 •

Copy link
Copy Markdown

Deploy preview for fa-reactjs ready!

Built with commit 2aa36f5

https://deploy-preview-127--fa-reactjs.netlify.com

@BaseMax
BaseMax requested a review from tesseralis January 18, 2020 12:58
@sorousht

Copy link
Copy Markdown
Contributor

Hi @BaseMax

Thanks for translating these pages.
I just assigned Fragments to you here #1. This is how we manage translations. The contributors usually leave a comment here #1 to ask if their desired page is available first.

Unfortunately, content/docs/reference-react-dom.md was assigned to @Abolfazl2647 previously. I forgot to add the label assigned to issue #105 in order to prevent any confusion. There is an open PR #126 for that page.

Every PR should contain only one page. This makes it easier to manage the PRs and review them. Can you please submit a new PR for Fragments?

Then we find a way to use your translation of reference-react-dom.md later on.

Thank you again,
Soroush

@BaseMax

BaseMax commented Jan 18, 2020

Copy link
Copy Markdown
Author

Dear @sorousht,

Sorry, But this was a problem.
He did not mention it at Issue page. #105

I close this PR, I will create one by one pages in new seperate PR.

Sorry for my mistake. 😭
Please be here for fast review. 👍
Thank you ❤️

Best,
Max

@BaseMax BaseMax closed this Jan 18, 2020
@sorousht

Copy link
Copy Markdown
Contributor

I've to mention that you would better have only one page in-progress. This means you should wait for your first PR to be reviewed, and then you'll be given another page.

@sorousht

Copy link
Copy Markdown
Contributor

Dear @BaseMax

It was actually my mistake and I apologize for that. We will definitely use your effort to improve the translation of reference-react-dom.md. First, let's just focus on Fragments.

Thanks,
Soroush

@BaseMax BaseMax mentioned this pull request Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants