Repository navigation
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 3, 2017
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@ide is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ide
pushed a commit
that referenced
this pull request
Nov 4, 2017
Summary: Resolves #16663. Walked through the reproduction steps in #16663, but with successful build. We can also now see the files are included in the `Pods` project: <img width="236" alt="screen shot 2017-11-03 at 7 43 21 pm" src="https://user-images.githubusercontent.com/33126/32390596-4a06c05c-c0cf-11e7-8616-3ae547f8cca2.png"> (I noticed a subspec called `_ignore_me_subspec_for_linting_` so do we have tests for the podspec?) [IOS] [BUGFIX] [React.podspec] - Resolves build error about missing symbols for PrivateDatabase.{cpp,h} Closes #16664 Differential Revision: D6238178 Pulled By: hramos fbshipit-source-id: b57007ab8c7c8bd0faf1f2f11269a7a2c28183e5
ide
pushed a commit
that referenced
this pull request
Nov 4, 2017
Summary: Resolves #16663. Walked through the reproduction steps in #16663, but with successful build. We can also now see the files are included in the `Pods` project: <img width="236" alt="screen shot 2017-11-03 at 7 43 21 pm" src="https://user-images.githubusercontent.com/33126/32390596-4a06c05c-c0cf-11e7-8616-3ae547f8cca2.png"> (I noticed a subspec called `_ignore_me_subspec_for_linting_` so do we have tests for the podspec?) [IOS] [BUGFIX] [React.podspec] - Resolves build error about missing symbols for PrivateDatabase.{cpp,h} Closes #16664 Differential Revision: D6238178 Pulled By: hramos fbshipit-source-id: b57007ab8c7c8bd0faf1f2f11269a7a2c28183e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #16663.
Test Plan
Walked through the reproduction steps in #16663, but with successful build.
We can also now see the files are included in the
Podsproject:(I noticed a subspec called
_ignore_me_subspec_for_linting_so do we have tests for the podspec?)Release Notes
[IOS] [BUGFIX] [React.podspec] - Resolves build error about missing symbols for PrivateDatabase.{cpp,h}