[0.51] Commits to cherry-pick into stable release

@ide

The thread containing issues that are blocking 0.51 release and need to be addressed.

Before posting your comment, please read the below quote by @ide:

Please keep this list to critical bug fixes that are new in 0.51 and ideally have been merged into master -- post commit hashes rather than issue/PR numbers unless the issue/PR in question targets a problem specific to 0.51. The intent of these cherry-pick threads is not to solicit features but to fix things that make 0.51 substantially more launch-blocked than 0.50. This is an example of an appropriate PR, which fixes the Podspec so 0.51 compiles: #16664

Would be great to have these: #16429, #14720, and especially #16456

Would be amazing if this was addressed: #10999

Please keep this list to critical bug fixes that are new in 0.51 and ideally have been merged into master -- post commit hashes rather than issue/PR numbers unless the issue/PR in question targets a problem specific to 0.51. The intent of these cherry-pick threads is not to solicit features but to fix things that make 0.51 substantially more launch-blocked than 0.50.

This is an example of an appropriate PR, which fixes the Podspec so 0.51 compiles: #16664

Cherry-picked 2a24b7b (Podspec fix) and a follow-up commit into 0.51-stable.

For next issue template, I'll probably include this as a default issue description.

Please can we have 3f1b021
It addresses Android inconsistencies when interpreting line height described here: #10712

Many thanks.

Right now 0.51.0-rc.0 is not out yet on npm due to issues with CircleCI. Until that happens, please hold with posting commits to cherry-pick - all in all you don't know what is broken and needs a fix and what's not :)

@svbutko

@svbutko and @robblovell, PRs that you have linked are not yet merged into master and I don't see how they could be critical to this release.

I've deleted other, not related comments in this thread. Please keep it to the point and post comments as per @ide guidelines.

ee3532b & b9e7006

@charpeni

@charpeni I see that the commit you have nominated is more a minor feature rather than a hotfix. Would you mind providing a bit more context as to why you would like this one to be cherry-picked?

ee3532b - Without this fix, our logs in iOS are spamed with this warning:

Module RCTTVNavigationEventEmitter requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

b9e7006 - Nit picking in the previous warning message, can be omitted.

It seems that 0.51.0-rc.3 is not released in NPM yet, please help 😄

@grabbou

@grabbou , this pipeline info brings not much if we can see that it stuck on hold for few days ;)
And you told us it's gonna be released 3 days ago :)
So, why still on hold?

I see there is 0.51.0-rc.2 on npm, ok, it's all about 51-RC for now.

This particular build has been on hold because of CircleCI issues. I tried enabling it many times to "pass" the release, but it didn't work (they had outage). I'll just go ahead and release a stable version in the afternoon today.

…

On Mon, 4 Dec 2017 at 02:38 chrusart ***@***.***> wrote: @grabbou <https://github.com/grabbou> , this pipeline info brings not much if we can see that it stuck on hold for few days ;) So, why still on hold? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16614 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxqzIb2xXQYZJ89IhpbO9-MKADmgaks5s88uQgaJpZM4QMpSy> .

Actually, I managed to make it run this time -> https://circleci.com/gh/facebook/react-native/27792

…

On Mon, 4 Dec 2017 at 07:33 Mike Grabowski ***@***.***> wrote: This particular build has been on hold because of CircleCI issues. I tried enabling it many times to "pass" the release, but it didn't work (they had outage). I'll just go ahead and release a stable version in the afternoon today. On Mon, 4 Dec 2017 at 02:38 chrusart ***@***.***> wrote: > @grabbou <https://github.com/grabbou> , this pipeline info brings not > much if we can see that it stuck on hold for few days ;) > So, why still on hold? > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#16614 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACWcxqzIb2xXQYZJ89IhpbO9-MKADmgaks5s88uQgaJpZM4QMpSy> > . >

@grabbou

@grabbou is 0.51.0 supposed to be available in npm right now? I only see 0.50.4 still. It shows success in your circleci link but I'm not exactly sure what this entails. Sorry if I'm jumping the gun and thanks for your time.

@jslok

@jslok it's 0.51.0-rc.3 build for now.

It's on npm.

@grabbou

0.51.0-rc.3 seems like the best option for now since stable release isn't up yet. Wondering where the best place is to look at a change log @grabbou ? Thanks!

Stable is out, you can see the changelog in the "Releases" tab on Github :)

…

On Tue, 5 Dec 2017 at 11:59 Richard Girges ***@***.***> wrote: 0.51.0-rc.3 seems like the best option for now since stable release isn't up yet. Wondering where the best place is to look at a change log @grabbou <https://github.com/grabbou> ? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16614 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxkvJVffi_MejFcBpbIK-vdSer9s_ks5s9aC-gaJpZM4QMpSy> .

@grabbou

@grabbou in stable, flowconfig is set for version 0.57.0 there is no such version. Only 0.57.1 or .2 or .3. when I do npm i flow-bin@0.57.0 --save-dev it says no such package.

I'm late to this but if my analysis is correct, #17030 seems to be a serious regression that should be fixed in v0.51.

Subscribed and will be awaiting status. For now, going to close this one as no cherry-picks to stable anymore except the bug fixes that we will track separately.

Going to roll out 0.52.0-rc.0 in the meantime.

Navigation Menu

Repository navigation

[0.51] Commits to cherry-pick into stable release #16614

6 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[0.51] Commits to cherry-pick into stable release #16614

Description

Activity

svbutko commented on Oct 31, 2017

robblovell commented on Nov 3, 2017

ide commented on Nov 3, 2017

grabbou commented on Nov 4, 2017

dickie81 commented on Nov 6, 2017

grabbou commented on Nov 7, 2017

grabbou commented on Nov 7, 2017

charpeni commented on Nov 27, 2017

grabbou commented on Nov 27, 2017

charpeni commented on Nov 27, 2017

6 remaining items

patw0929 commented on Dec 4, 2017

chrusart commented on Dec 4, 2017

grabbou commented on Dec 4, 2017

grabbou commented on Dec 4, 2017

jslok commented on Dec 5, 2017

chrusart commented on Dec 5, 2017

richardgirges commented on Dec 5, 2017

grabbou commented on Dec 6, 2017

Noitidart commented on Dec 6, 2017

tiagoalves commented on Dec 7, 2017

grabbou commented on Dec 7, 2017

grabbou commented on Dec 7, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions