Repository navigation
Online yarn installs created an undesired package install #1684
Description
I just installed create-react-app with yarn global add create-react-app and created a project.
When i was looking through the dependencies i found out this
{
"name": "blue",
"version": "0.1.0",
"private": true,
"dependencies": {
"false": "0.0.4",
"react": "^15.4.2",
"react-dom": "^15.4.2"
},
"devDependencies": {
"react-scripts": "0.9.3"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --env=jsdom",
"eject": "react-scripts eject"
}
}
And i was not sure what was "false":"0.0.4", while looking at the module i found out that false was just like another leftpad. I find it hard to reason why has been included in cra. If it was intended to be included sorry, i just found odd.
// false module source code :/
module.exports = function () {
return false;
};
Activity
tox-p commentedon Feb 28, 2017
Same issue here, already did some digging.
The false package is there because this line evaluates to false when installing with yarn while online. If you install offline (or with npm) the dependency on the false package is not included.
lpalmes commentedon Feb 28, 2017
@tox-p you are right, it's using the false value as the name package
lpalmes commentedon Feb 28, 2017
@Timer just added #1685 to pull requests which fixies this issue.
Timer commentedon Feb 28, 2017
Thanks so much! Please see comment in #1685.
Timer commentedon Mar 1, 2017
I'm going to reopen this because I want to remember to add you to a changelog [somewhere]. 😄 Our fixes were virtually identical, and you deserve some recognition for acting so fast.
[-]"false":"0.0.4" on package.json[/-][+]Online yarn installs created an undesired package install[/+]lpalmes commentedon Mar 1, 2017
Thanks @Timer, It is not necessary but i really appreciate it. I've been using cra for a long time, so i was happy to give something back 😄
gaearon commentedon Mar 5, 2017
@lpalmes
Would you be interested in adding a test for this to the end-to-end script, as mentioned in #1685 (comment)?
gaearon commentedon Mar 5, 2017
I’m going to close this one, but happy to accept @lpalmes’s contributions for #1720.
lpalmes commentedon Mar 5, 2017
@gaearon i've been looking at it and now that i got more time (had to deliver a mobile app) i will try to come up with a solution, i'm looking into awk to add testing in the script, thank you, and sorry for taking such a long time.
gaearon commentedon Mar 5, 2017
No worries, thanks for helping!