Check for accidental extraneous dependencies in end-to-end-tests #1720

Activity

1. gaearon

   added

   tag: internal

   on Mar 5, 2017
2. gaearon

   added this to the 0.10.0This milestone has been deleted milestone on Mar 5, 2017
3. lpalmes commented on Mar 6, 2017

   

   lpalmes

   on Mar 6, 2017

   Last edited by lpalmes

   Contributor

   More actions

   @gaearon @Timer,
   I've been testing some awk commands a bit

   $ awk '/dependencies/{y=1;next}/},/{y=0; next}y' package.json
       "react": "^15.4.2",
       "react-dom": "^15.4.2"
   $ awk '/devDependencies/{y=1;next}/},/{y=0; next}y' package.json
       "react-scripts": "0.9.4"
   

   This will get between the word dependencies and the closing bracket below the dependencies, i only need to check if every dependency is correct.
   If you have any ideas how to do this let me know, i was thinking it could be possible to partly match each line to react
4. Timer commented on Mar 8, 2017

   

   Timer

   on Mar 8, 2017

   Last edited by Timer

   Contributor

   More actions

   I've been a bit busy, @lpalmes -- sorry for not giving you a quicker response.
   We can probably grep inverted what comes back from that, validating they're packages we want:

   awk '/dependencies/{y=1;next}/},/{y=0; next}y' package.json | \
     grep -v -q -E '^\s*"react(?:-dom|-scripts)?"'

   -v is invert match & -q is quiet -- we only care about the return code .

   Then just test to make sure the result of that is not 0, because 0 would mean it found something extraneous!
5. Timer

   added

   contributions: claimed

   on Mar 9, 2017
6. Timer commented on Mar 14, 2017

   

   Timer

   on Mar 14, 2017

   Contributor

   More actions

   @lpalmes Hi! How's everything going?
   Would you like to finish this? 😄 If you're too short on time, that's alright too.
7. lpalmes commented on Mar 14, 2017

   

   lpalmes

   on Mar 14, 2017

   Last edited by lpalmes

   Contributor

   More actions

   I was traveling, got back yesterday, sorry for the absence.
   I will add it today, i let you know otherwise today @Timer
8. Timer commented on Mar 14, 2017

   

   Timer

   on Mar 14, 2017

   Contributor

   More actions

   Sweet, thanks @lpalmes!
   Hope you enjoyed your travels & were safe! 😄
9. lpalmes commented on Mar 14, 2017

   

   lpalmes

   on Mar 14, 2017

   Contributor

   More actions

   Thanks @Timer, i've enjoyed it and managed to meet lot of developers and companies, just what i was looking for 😄 , really great experience.
   I've just sent the pull request to fix this. I've tried on my computer, and it worked quite nicely. I've added some random deps to package.json and confirmed that errors correctly.
10. Timer

    closed this as completedin #1825on Mar 23, 2017
11. lock

    locked and limited conversation to collaborators on Jan 22, 2019