[mikehardy]

Summary:

I just saw that the CLI has a new clean command. That's fantastic!

Historically I steer people to https://github.com/pmadruga/react-native-clean-project but really it's basic functionality, glad to see it in the CLI.

I had a problem that I PRd to react-native-clean-project regarding cocoapods spec cache poisoning, and install / unpack failures, and they were solved by also cleaning ~/.cocoapods and cleaning ios/Pods so I am PR'ing that here

I understand paths might be an issue but since we are inside an os === darwin conditional, the ~/ should be okay. I'm not sure about the ios/ though and will happily take guidance

Test Plan:

In practice for a long time, here:

https://github.com/pmadruga/react-native-clean-project/blob/65c012ed0dcf4ea6786af867e8a7b1c1ee00be86/source/internals/tasks.js#L8-L22

  wipeiOSPodsFolder: {
    name: 'wipe iOS Pods folder',
    command: 'rm',
    args: ['-rf', 'ios/Pods']
  },
  wipeSystemiOSPodsCache: {
    name: 'wipe system iOS Pods cache',
    command: 'cd ios & pod',
    args: ['cache', 'clean', '--all']
  },
  wipeUseriOSPodsCache: {
    name: 'wipe user iOS Pods cache',
    command: 'rm',
    args: ['-rf', '~/.cocoapods']
  },

[mikehardy]

config guide for quick cross-check if desired https://github.com/actions/setup-java#caching-gradle-dependencies

• they use the single quotes around strings, that's best practice in YAML
• zulu is the name they use for the JDK series that corresponds to current react native guide https://reactnative.dev/docs/environment-setup

[mikehardy]

v3 is current (well, v3.3.0 is, but they move the v3 tag along with releases) https://github.com/actions/setup-java/tags

[cortinico]

LGTM 👍

[mikehardy]

Nice! this looks much better, I hate seeing that red...

[thymikee]

I guess I got used to it. Thank you for tackling this @mikehardy 🙇🏼‍♂️