[mikehardy]

Summary:

The template now inits a compileSdk/targetSdk 31 project,
JDK8 cannot compile reliably against SDK31, so bump JDK as well

I will mark this as draft, it should get a few more commits:

• https://github.com/react-native-community/cli/blob/master/packages/cli-doctor/src/tools/healthchecks/jdk.ts updated to latest v11 URL for windows and ideally to adoptium
• manual JDK fix instructions point to environment setup on reactnative.dev now
• updated versions / URLs to all this stuff https://github.com/react-native-community/cli/blob/master/packages/cli-doctor/src/tools/healthchecks/androidSDK.ts here

Test Plan:

seems to work for me locally?

Each commit is separate and useful, they should be removed commit by commit to make it all crystal clear

☠️ : ⚠️ the ! in the commit message is a good idea or not, to drive a breaking change semver? ⚠️ ☠️ :

[mikehardy]

This should be extended to be react-native version specific, it should only fail on JDK11 if react-native is >= 0.68

[grabbou]

@mikehardy any update on this PR as it's still marked as draft?

[mikehardy]

No progress yet, hoping for a timeslice fir CLI work in a day or two but meeting a contract work deadline first. I'll never take offense if someone just runs with anything I've started though, as long as like you did they drop me a note 😁

Next step here is to personally learn how to access what version of react-native is in play, and start doing checks that provide different guidance based on different rn version

[mikehardy]

@grabbou forgot I still had this one out here is draft. Was in CLI repo just looking to verify something (I needed to toss someone the link to PR removing react-native link functionality and now you got me for two PRs ;-)

[mikehardy]

e2e is going to fail until #1620 is merged because it has the github actions bump to JDK 11

[mikehardy]

verified this matches template in react-native repo right now

[mikehardy]

I forgot to update tests, my apologies. In progress.

[mikehardy]

fixed tests, cherry-picked the JDK11 CI fix from #1620,

I can rebase that CI JDK11 fix out and re-push or mash the commits around however as needed depending on PR merge order / preference here

[thymikee]

Thank you!