Skip to content

[ExecuTorch][Vulkan] SDK Integration 4/n: Expose QueryPool data to ComputeGraph - #3960

Closed
liuk22 wants to merge 1 commit into
gh/liuk22/4/basefrom
gh/liuk22/4/head
Closed

liuk22 wants to merge 1 commit into
gh/liuk22/4/basefrom
gh/liuk22/4/head

Conversation

@liuk22

@liuk22 liuk22 commented Jun 12, 2024 •

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

See design doc.

4/n: Expose QueryPool data to ComputeGraph

  • I make a simple change to QueryPool given the complexity of its lifecycle now and deviate from the design of VulkanProfiler. We can implement more of those feature later.
  • Turn the shader data into vector of tuples

Differential Revision: D57426500

…mputeGraph

See [design doc](https://docs.google.com/document/d/1KQ0vH0IhZK24sBbym7TYXfYssAgtPjI-htcxraoxEaM/edit).

__4/n: Expose QueryPool data to ComputeGraph__
- I make a simple change to QueryPool given the complexity of its lifecycle now and deviate from the design of `VulkanProfiler`. We can implement more of those feature later.
- Turn the shader data into vector of tuples

Differential Revision: [D57426500](https://our.internmc.facebook.com/intern/diff/D57426500/)

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jun 12, 2024 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3960

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3c90a9c with merge base 10de8b2 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added ciflow/periodic module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels Jun 12, 2024
@pytorch-bot

pytorch-bot Bot commented Jun 12, 2024

Copy link
Copy Markdown

Warning: Unknown label ciflow/periodic.
Currently recognized labels are

  • ciflow/nightly
  • ciflow/trunk
  • ciflow/binaries
  • ciflow/binaries/all

Please add the new label to .github/pytorch-probot.yml

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 12, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D57426500

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in d000224.

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
…mputeGraph

See [design doc](https://docs.google.com/document/d/1KQ0vH0IhZK24sBbym7TYXfYssAgtPjI-htcxraoxEaM/edit).

__4/n: Expose QueryPool data to ComputeGraph__
- I make a simple change to QueryPool given the complexity of its lifecycle now and deviate from the design of `VulkanProfiler`. We can implement more of those feature later.
- Turn the shader data into vector of tuples

Differential Revision: [D57426500](https://our.internmc.facebook.com/intern/diff/D57426500/)

ghstack-source-id: 229964243
Pull Request resolved: pytorch/executorch#3960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants