Repository navigation
Conversation
See [design doc](https://docs.google.com/document/d/1KQ0vH0IhZK24sBbym7TYXfYssAgtPjI-htcxraoxEaM/edit). __3/n: QueryPool with node_id__ - Now we have the full E2E linked of a coherent DDI, serialized AOT to the flatbuffer, deserialized Runtime to `ShaderInfo`. - We add `node_id` as default-valued argument (`UINT32_MAX`) to `Context::submit_compute_job()` which allows`ShaderDuration` to be constructed later with `node_id` - I modify `QueryPool::shader_profile_begin()` , `Context::report_shader_dispatch_start()`, to construct `ShaderDuration` with the `node_id` from `ExecuteNode` Differential Revision: [D57424317](https://our.internmc.facebook.com/intern/diff/D57424317/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3959
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ebc5caa with merge base 10de8b2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
Bot
added
ciflow/periodic
module: vulkan
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57424317 |
This was referenced Jun 12, 2024
copyrightly
approved these changes
Jun 12, 2024
Contributor
|
This pull request has been merged in 8f3ae8d. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
See [design doc](https://docs.google.com/document/d/1KQ0vH0IhZK24sBbym7TYXfYssAgtPjI-htcxraoxEaM/edit). __3/n: QueryPool with node_id__ - Now we have the full E2E linked of a coherent DDI, serialized AOT to the flatbuffer, deserialized Runtime to `ShaderInfo`. - We add `node_id` as default-valued argument (`UINT32_MAX`) to `Context::submit_compute_job()` which allows`ShaderDuration` to be constructed later with `node_id` - I modify `QueryPool::shader_profile_begin()` , `Context::report_shader_dispatch_start()`, to construct `ShaderDuration` with the `node_id` from `ExecuteNode` Differential Revision: [D57424317](https://our.internmc.facebook.com/intern/diff/D57424317/) ghstack-source-id: 229964242 Pull Request resolved: pytorch/executorch#3959
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
See design doc.
3/n: QueryPool with node_id
ShaderInfo.node_idas default-valued argument (UINT32_MAX) toContext::submit_compute_job()which allowsShaderDurationto be constructed later withnode_idQueryPool::shader_profile_begin(),Context::report_shader_dispatch_start(), to constructShaderDurationwith thenode_idfromExecuteNodeDifferential Revision: D57424317