Skip to content

[ExecuTorch][Vulkan] Preserve persistent buffer mutations - #21597

Merged
meta-codesync[bot] merged 1 commit into
gh/JCNTH/204/basefrom
gh/JCNTH/204/head
Aug 7, 2026
Merged

meta-codesync[bot] merged 1 commit into
gh/JCNTH/204/basefrom
gh/JCNTH/204/head

Conversation

@JCNTH

@JCNTH JCNTH commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Preserve functional persistent-buffer updates in VK00 graphs

Voxtral Realtime updates streaming state through functionalized buffer mutations. Serialization previously assigned those updates a separate tensor ID, preventing later calls from reading the persistent input buffer.

Key changes:

  • alias_buffer_mutations — adds a default-off compile option.
  • VkGraphBuilder — reuses persistent input or exact et_vk.prepack storage IDs for mutation outputs.
  • Delegate outputs — suppress mutation-only results while preserving nodes that are also user outputs.

Absent or false alias_buffer_mutations preserves existing Vulkan graph values and output IDs.

Co-authored-with: Claude Code.

Differential Revision: D114936148

[ghstack-poisoned]
@JCNTH
JCNTH requested a review from SS-JIA as a code owner August 5, 2026 19:54
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Aug 5, 2026
@pytorch-bot

pytorch-bot Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21597

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit eb4d832 with merge base ad3a71f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
meta-codesync Bot merged commit c62cfef into gh/JCNTH/204/base Aug 7, 2026
182 of 187 checks passed
@meta-codesync
meta-codesync Bot deleted the gh/JCNTH/204/head branch August 7, 2026 17:22
@meta-codesync
meta-codesync Bot temporarily deployed to cherry-pick-bot August 7, 2026 17:22 Inactive
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>
JCNTH added a commit that referenced this pull request Aug 7, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #21597 by
@JCNTH
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/JCNTH/203/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/JCNTH/204/orig
Differential Revision:
[D114936148](https://our.internmc.facebook.com/intern/diff/D114936148/)
@diff-train-skip-merge

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

---------

Co-authored-by: Julian Ng-Thow-Hing <juliannth@meta.com>
Co-authored-by: Julian Ng-Thow-Hing <107437036+JCNTH@users.noreply.github.com>

This branch was previously deployed

2 inactive deployments
cherry-pick-bot — eb4d8320 Deployed Aug 7, 2026 by meta-codesync[bot] via Try to create a PR with ghstack /orig branch #1606
cadence — eb4d8320 Deployed Aug 5, 2026 by JCNTH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants