Repository navigation
Remove section on incomplete/partial stubs from CONTRIBUTING.md - #8962
Closed
ramvikrams wants to merge 2 commits into
Closed
ramvikrams wants to merge 2 commits into
ramvikrams wants to merge 2 commits into
Conversation
for issue #8955
sobolevn
reviewed
Oct 22, 2022
|
|
||
| We accept partial stubs, especially for larger packages. These need to | ||
| follow the following guidelines: | ||
| We accept partial stubs, especially for larger packages. The only guidline that needs to be followed is: |
Member
There was a problem hiding this comment.
Let's put it like this:
We generally prefer complete stubs, but larger packages can be submitted with some incomplete non-essential parts.
Author
There was a problem hiding this comment.
Thanks sir I will do the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue #8955 removed the lines as mentioned in the issue