Skip to content

Remove section on incomplete/partial stubs from CONTRIBUTING.md - #8962

Closed
ramvikrams wants to merge 2 commits into
python:mainfrom
ramvikrams:T1
Closed

ramvikrams wants to merge 2 commits into
python:mainfrom
ramvikrams:T1

Conversation

@ramvikrams

Copy link
Copy Markdown

for issue #8955 removed the lines as mentioned in the issue

Comment thread CONTRIBUTING.md Outdated

We accept partial stubs, especially for larger packages. These need to
follow the following guidelines:
We accept partial stubs, especially for larger packages. The only guidline that needs to be followed is:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put it like this:

We generally prefer complete stubs, but larger packages can be submitted with some incomplete non-essential parts.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks sir I will do the change

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done the changes

@AlexWaygood AlexWaygood linked an issue Nov 10, 2022 that may be closed by this pull request
@AlexWaygood AlexWaygood changed the title change in contributing.md Remove section on incomplete/partial stubs from CONTRIBUTING.md Nov 12, 2022
@ramvikrams ramvikrams closed this by deleting the head repository Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove partial classes/modules from CONTRIBUTING?

2 participants