Skip to content

Remove partial classes/modules from CONTRIBUTING? #8955

Closed

Description

@srittau

We still have a section about "Incomplete stubs" in CONTRIBUTING. I believe we should remove this as nowadays stubs are generally generated using stubgen, so this shouldn't be an issue anymore. I don't want to encourage new incomplete stubs, and it makes the CONTRIBUTING file a longer read.

We only should leave the sentence about unannotated arguments and return values.

Activity

  1. ramvikrams commented on Oct 21, 2022

    @ramvikrams

    Done with the changes

  2. Avasam commented on Nov 12, 2022

    @Avasam
    SponsorCollaborator

    With this, should ignore_missing_stub default to false? Since "we don't want to encourage new incomplete stubs". It's mainly needed for stubs that are already present and incomplete, or would result in an allowlist that's too complex. (the create_baseline_stubs script does set it to false, I'm thinking about running stubtest with it false by default)

  3. added a commit that references this issue on Jan 16, 2023
    a730e2f
  4. added a commit that references this issue on Feb 3, 2023
    cd64563
  5. added and removed on Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    project: infrastructuretypeshed build, test, or distribution relatedproject: policyOrganization of the typeshed project

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions