Skip to content

Fix requests.Session().hooks #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 3 commits into from
May 19, 2022
Merged

Fix requests.Session().hooks #7871

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0659341
Use `dict` for requests.Session().hooks
Akuli May 18, 2022
a2912b9
try the Any trick
Akuli May 18, 2022
95a494c
just get rid of the type alias
Akuli May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions stubs/requests/requests/sessions.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ _Files: TypeAlias = (
| Mapping[str, tuple[str | None, SupportsRead[str | bytes] | str | bytes, str, _TextMapping]]
)
_Hook: TypeAlias = Callable[[Response], Any]
_Hooks: TypeAlias = Mapping[str, _Hook | list[_Hook]]
_HooksInput: TypeAlias = Mapping[str, Iterable[_Hook] | _Hook]

_ParamsMappingKeyType: TypeAlias = str | bytes | int | float
Expand Down Expand Up @@ -85,7 +84,10 @@ class Session(SessionRedirectMixin):
headers: CaseInsensitiveDict[str | bytes]
auth: _Auth | None
proxies: _TextMapping
hooks: _Hooks
# Don't complain if:
# - value is assumed to be a list (which it is by default)
# - a _Hook is assigned directly, without wrapping it in a list (also works)
hooks: dict[str, list[_Hook] | Any]
params: _Params
stream: bool
verify: None | bool | str
Expand Down