Repository navigation
Fix requests.Session().hooks - #7871
Merged
Merged
Conversation
Fixes #7776 Mutating hooks, as in `session.hooks['response'] = ...`, should work. Reassigning it like `session.hooks = ...` is probably a bad idea, so it will always be a `dict`.
Akuli
marked this pull request as draft
May 18, 2022 21:40
Collaborator
Author
|
We still need to discuss whether it's better to use a union or just require hooks to be lists. The usual reason for avoiding union return types applies here: if we merge this PR as is, #7776 still wouldn't work, because it would end up calling |
Akuli
changed the title
dict for requests.Session().hooks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
marked this pull request as ready for review
May 18, 2022 21:59
JelleZijlstra
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7776
Mutating hooks, as in
session.hooks['response'] = ..., should work. Reassigning it likesession.hooks = ...is probably a bad idea, so it will always be adict.