Repository navigation
Add back cachetools stubs - #6096
Merged
Merged
Conversation
This reverts commit 32bc216.
srittau
approved these changes
Sep 30, 2021
srittau
left a comment
Collaborator
There was a problem hiding this comment.
It seems cachetools 4.2.4 re-added the missing modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were previously removed in #6093
cachetools.FIFOCache, a new functioncachetools.func.fifo_cache, a new modulecachetools.fifo, and similarly for MRU.cachetools.fifoandcachetools.lru, are now deprecated. Each of them contains one class that is also available directly incachetools, sofrom cachetools.lru import LRUCacheis deprecated in favor offrom cachetools import LRUCache.timerargument ofcachetools.func.ttl_cachenow has the correct type. Previously it was a float, even though it should be a callable that returns a float.This is probably easiest to review as a whole, not commit-by-commit. Cachetools is not a big package.