Repository navigation
Use _typeshed.Self with __enter__ - #5712
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Jun 29, 2021
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Thanks! I double-checked all these except the Python 2 stuff.
|
|
||
| class BZ2File(BaseStream, IO[bytes]): | ||
| def __enter__(self: _T) -> _T: ... | ||
| def __enter__(self: Self) -> Self: ... |
Member
There was a problem hiding this comment.
This method doesn't actually exist at runtime; I guess it is inherited from an IO-related base class.
Contributor
Author
There was a problem hiding this comment.
You are correct, I think it is IOBase, but I would need to check.
graingert
reviewed
Jul 3, 2021
Contributor
|
Probably needs a scan for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #5676
I also removed
TypeVarusage, where it became obsolete. IncProfileit also made sense to replace the_SelfTreferences withSelf.