Repository navigation
Improve the self types situation #5676
Description
From micro codery on typing-sig:
It was only after seeing the solution that I could find docs describing it on mypy.readthedocs. There is a note claiming that a generic self is still experimental but maybe a convention should be added to the typeshed contributing guide about using it, just like Sequence is recommended over list.
I suggest that in the future we shouldn't accept
__enter__()methods returningselfanymore that don't use a type var.
I think we should do both of these things. We can find some existing offenders with git grep 'def __enter__(self) -> [A-Z]'.
Activity
srittau commentedon Jun 22, 2021
We can also add a
Selftype var to_typeshed:This can help us finding places where we should use
typing.Selfif this proposal is accepted.Add Self type var to _typeshed
Add Self type var to _typeshed (#5677)
Recommend `Self` in CONTRIBUTING.md
Recommend `Self` in CONTRIBUTING.md (#5699)
gruebel commentedon Jul 6, 2021
I think all of the work is done in the
stdlib, except for Python 2 types. Do you also want to tackle it or just leave it as it is?srittau commentedon Jul 6, 2021
Personally, I would not put the work into Python 2 stubs, but I would accept PRs improving them.
gruebel commentedon Jul 6, 2021
I'm also not up to put some work into Python 2 stubs 😄 so next would be the stubs under the
stubsfolder, right?JelleZijlstra commentedon Dec 14, 2021
Looks like there's no work left. (I forgot what Python 2 is.)