Repository navigation
Make NamedTuple accept Text names (#2761). - #2762
Merged
Merged
Conversation
srittau
requested changes
Feb 9, 2019
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the fix, but please use Text per CONTRIBUTING file. We have gone a bit to and fro in the past around this issue, but this is what we have settled on and should be the most compatible.
Collaborator
|
(Also restarted CI, since the travis failure did not seem related to the PR.) |
srittau
reviewed
Feb 9, 2019
panhania
changed the title
NamedTuple accept AnyStr names (#2761).NamedTuple accept Text names (#2761).
srittau
approved these changes
Feb 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both type and field names of
NamedTuplecan be specified with unicode strings now.This fixes #2761.