Repository navigation
typing.NamedTuple should accept unicode names #2761
Description
Currently, NamedTuple has the following signature associated with its constructor:
def __init__(self, typename: str, fields: Iterable[Tuple[str, Any]] = ..., *,
verbose: bool = ..., rename: bool = ..., **kwargs: Any) -> None: ...This causes type checking to fail in Python 2 for modules where unicode_literals is enabled since this function is usually called this way:
Foo = NamedTuple("Foo", (("bar", Bar), ("baz", Baz)))Instead, typename should have type AnyStr and fields should have type Iterable[Tuple[AnyStr, Any]].
Activity
Make `NamedTuple` accept `AnyStr` names (python#2761).
[-]`typing.NamedTuple` should accept `AnyStr` names[/-][+]`typing.NamedTuple` should accept `unicode` names[/+]JelleZijlstra commentedon Jan 23, 2019
Thanks for the report and fix!
Just to be clear, there is no such thing as an AnyStr value, since AnyStr is a type variable.
panhania commentedon Jan 23, 2019
Ah, good to know. I was sure that
AnyStris just an alias forUnion[str, unicode]but apparently I was wrong.I think in this particular case
AnyStrshould work just fine for most real world scenarios:NamedTupleis used in a "static" way with string literals and people use either bytestring literals or unicode literals without mixing the two. Nevertheless,Union[str, unicode]is obviously more general so I have fixed the code.Make `NamedTuple` accept `Text` names (#2762)