Skip to content

stubtest-complete grpcio plugins - #13932

Merged
srittau merged 4 commits into
python:mainfrom
Avasam:stubtest-complete-grpcio-plugins
May 5, 2025
Merged

srittau merged 4 commits into
python:mainfrom
Avasam:stubtest-complete-grpcio-plugins

Conversation

@Avasam

@Avasam Avasam commented May 3, 2025 •

Copy link
Copy Markdown
Collaborator

Split off from #13896 for ease of review

Note that this doesn't aim to make the grpcio stubs "complete" (for stubtest). Only its plugins(?) (which I'm splitting off into distributions in #13896 )

This includes the stubdefaulter run. (If reviewers prefer, I can split that off as well)

@github-actions

github-actions Bot commented May 3, 2025

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

dd-trace-py (https://github.com/DataDog/dd-trace-py)
+ ddtrace/appsec/_iast/_handlers.py:28: error: Module "google._upb._message" has no attribute "MessageMapContainer"  [attr-defined]
+ ddtrace/appsec/_iast/_handlers.py:28: note: Error code "attr-defined" not covered by "type: ignore" comment

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checking: LGTM

@srittau
srittau merged commit 2b2ea71 into python:main May 5, 2025
@Avasam
Avasam deleted the stubtest-complete-grpcio-plugins branch May 5, 2025 13:23
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants