Repository navigation
Running Black on *_pb2 files - #13930
Merged
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
May 3, 2025
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Yeah, I think this is fine personally
srittau
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #13929 and #13932 I have some non-autogenerated
*_pb2files I would've liked formatted.I could run manually or update the exclusion list.
But I'm thinking "why not just format them all?". Sure some long length can't be autofixed by Black, but it's not like it makes the run fail or anything.
We now run many autofixes on
*_pb2files. I don't see why Black couldn't apply as well.The only manual change is in
pyproject.toml