Repository navigation
PEP 661: Fix citation references - #2698
Merged
Merged
Conversation
CAM-Gerlach
approved these changes
Jul 5, 2022
CAM-Gerlach
left a comment
Member
There was a problem hiding this comment.
I usually make indirect external-link references anonymous, to avoid creating duplicate or unintended second-order reference targets, particularly for the rather generic words that are often linked.
Otherwise, LGTM. Thanks @hugovk !
Member
Author
|
Shall I update them to be anonymous? And if so, can you give me an example of the syntax? :) |
Member
Up to you, but you just add an extra trailing underscore, so instead of `link text <https://example.com>`_you do `link text <https://example.com>`__or in this case, instead of `link text <link-target_>`_you do `link text <link-target_>`__Find/replacing |
Member
Author
|
Thanks, that could save us some bother later, updated! |
Member
|
Thanks! I guess we can merge this then ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not referenced in the text. Let's fix by converting to a bullet list (like in #2644).
Let's also convert the remaining references to inline links, per #2130, and remove the redundant emacs metadata.
Preview
https://pep-previews--2698.org.readthedocs.build/pep-0661/