Repository navigation
PEP 554: Fix citation references - #2644
Merged
Merged
Conversation
AA-Turner
approved these changes
Jun 11, 2022
ericsnowcurrently
requested changes
Jun 13, 2022
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
Please leave orphaned references. The linked information still captures relevant information. It's fine if they are turned into bullets, or something similar, in the References section.
Other than that, LGTM.
hugovk
force-pushed
the
pep554-fix-warnings
branch
from
June 13, 2022 18:15
76e30ec to
5709966
Compare
Member
Author
|
Updated! How does this look? https://pep-previews--2644.org.readthedocs.build/pep-0554/#references |
ericsnowcurrently
approved these changes
Jun 14, 2022
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
LGTM
Thanks for the improvements!
Member
Author
|
Thanks for the reviews! |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixed by converting to inline links.
This citation was added in #419.
The text uses:
`Communicating Sequential Processes`_ (CSP)and:
So let's change this to a single citation:
Communicating Sequential Processes [CSP]_and:
This citation was added in #424, but removed/orphaned in #1390.
Let's remove the orphan.
Similarly, added in #426 and removed/orphaned in #944.