Repository navigation
PRS: Fix RSS generation and resolve all warnings - #2413
Merged
Merged
Conversation
AA-Turner
changed the title
CAM-Gerlach
reviewed
Mar 11, 2022
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
Member
There was a problem hiding this comment.
Thanks. One high-level comment and a couple nits.
CAM-Gerlach
approved these changes
Mar 11, 2022
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
Member
There was a problem hiding this comment.
LGTM at least from my end; @hugovk might have more substantive comments since he's more familiar with this script.
Member
Author
|
I'll merge this now in the interests of pragmatism, as RSS is currently broken and this is a fix. We can change in follow-ups if need be. A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2407, closes #2406
This builds on Hugo's fix to also fix everything else.
A