Skip to content

Infra: build peps.rss from input txt and rst files - #2407

Closed
hugovk wants to merge 2 commits into
python:mainfrom
hugovk:fix-rss
Closed

Infra: build peps.rss from input txt and rst files#2407
hugovk wants to merge 2 commits into
python:mainfrom
hugovk:fix-rss

Conversation

@hugovk

@hugovk hugovk commented Mar 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #2406.

The RSS builder must run on the input TXT and RST files, not the target HTML files, similar to how it was done in the old pep2rss.py:

peps/pep2rss.py

Lines 63 to 66 in 08e37f7

# get list of peps with creation time
# (from "Created:" string in pep .rst or .txt)
peps = glob.glob('pep-*.txt')
peps.extend(glob.glob('pep-*.rst'))

To test, run python3 generate_rss.py and check build/peps.rss has the most recently created PEPs.

For comparison, here's pep.rss from two days ago:

@hugovk
hugovk requested a review from AA-Turner as a code owner March 10, 2022 09:31
@hugovk hugovk mentioned this pull request Mar 10, 2022
Closed
@CAM-Gerlach CAM-Gerlach added bug infra Core infrastructure for building and rendering PEPs labels Mar 11, 2022
CAM-Gerlach
CAM-Gerlach approved these changes Mar 11, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from one minor suggestion you might want to consider

Comment thread generate_rss.py Outdated
@hugovk @CAM-Gerlach
RSS: More precise globbing
44e81f8 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
This was referenced Mar 11, 2022
Merged
Merged
@hugovk
hugovk deleted the fix-rss branch March 12, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees

No one assigned

Labels

bug CLA signed infra Core infrastructure for building and rendering PEPs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RSS doesn't seem to work anymore?

3 participants

@hugovk @CAM-Gerlach @the-knights-who-say-ni