Skip to content

Refine testcase and variable usage for "produce error when assigning NamedTuple to attribute" - #8112

Merged
ilevkivskyi merged 1 commit into
python:masterfrom
TH3CHARLie:refine-7662
Dec 9, 2019
Merged

ilevkivskyi merged 1 commit into
python:masterfrom
TH3CHARLie:refine-7662

Conversation

@TH3CHARLie

Copy link
Copy Markdown
Collaborator

Followed the discussion in #8107 (comment), refine the code merged in #7662 by:

  • move testcase from pythoneval.test to check-namedtuple.test and rename it from testNamedTupleAtRunTime to testAssignNamedTupleAsAttribute
  • change s.lvalues[0] to lvalue to make it more concise

@TH3CHARLie TH3CHARLie closed this Dec 9, 2019
@TH3CHARLie TH3CHARLie reopened this Dec 9, 2019
@TH3CHARLie

Copy link
Copy Markdown
Collaborator Author

Reopen to trigger travis-CI rebuild, previous build failed at runtime test suite on OSX with abnormal errors

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up!

@ilevkivskyi
ilevkivskyi merged commit ce0703a into python:master Dec 9, 2019
@TH3CHARLie
TH3CHARLie deleted the refine-7662 branch December 9, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants