Repository navigation
Produce error when assigning Enum or TypedDict as attribute - #8107
Merged
msullivan merged 1 commit intoDec 12, 2019
Merged
Conversation
Member
Yes, I think in a separate PR. |
ilevkivskyi
pushed a commit
that referenced
this pull request
Dec 9, 2019
…me for variable (#8112) Followed the discussion in #8107 (comment), refine the code merged in #7662 by: - move testcase from `pythoneval.test` to `check-namedtuple.test` and rename it from `testNamedTupleAtRunTime` to `testAssignNamedTupleAsAttribute` - change `s.lvalues[0]` to `lvalue` to make it more concise
Closed
msullivan
approved these changes
Dec 12, 2019
msullivan
left a comment
msullivan
left a comment
Collaborator
There was a problem hiding this comment.
This seems reasonable. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #8009, simply following solution by #7662
Additionally, when I was finishing the first version of the PR I noticed that some of #7662 could be refined:
mypy/mypy/semanal.py
Lines 2152 to 2154 in e8ae122
Here using
lvalueinstead ofs.lvalues[0]would be more concise.mypy/test-data/unit/pythoneval.test
Lines 1482 to 1492 in e8ae122
The test is in
pythoneval.test, but it makes more sense incheck-namedtuple.testand the name could be also changed accordingly.@ilevkivskyi What's your opinion on this? Should these changes be made? And if so, should they be made in this PR or a sperate one.